Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor governance content #69

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Refactor governance content #69

merged 2 commits into from
Jul 12, 2024

Conversation

jeffabailey
Copy link
Collaborator

@jeffabailey jeffabailey commented Jan 25, 2024

The goal of this PR is to move content centered around InnerSource governance to an appropriate location.

See this PR for reference: #40

chore: remove governance content from framework.md
- contribution process policies description

- monitoring policies and mechanisms description
Pick the right [governance standards and model](/governance/governance.md) for your organization.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrrutledge @spier

Given this context, I question whether or not linking to this file is the right approach.

#40 (comment)

image

We need to fundamentally decide if a hard copy of this book is a project goal. If it is, then we need to refer to the content with footnotes as suggested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that online book is what we're going for.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also say that an online book (effectively just a website) is our current target format.
gitbook provides us this format, as well as the possibility to do a PDF export, where links will likely be clickable as well.

@JustinGOSSES
Copy link
Contributor

@jeffabailey and @fioddor Is there any specific feedback one of you still needs to integrate here or can anyone approve and merge this now?

@jeffabailey
Copy link
Collaborator Author

@jeffabailey and @fioddor Is there any specific feedback one of you still needs to integrate here or can anyone approve and merge this now?

We have one approval.

If we can get one more, then I'll merge the change.

@dellagustin-sap dellagustin-sap self-requested a review July 12, 2024 13:25
Copy link
Contributor

@dellagustin-sap dellagustin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the content behind the link covers the content that was removed.

@jeffabailey jeffabailey marked this pull request as ready for review July 12, 2024 15:06
@jeffabailey jeffabailey requested a review from a team as a code owner July 12, 2024 15:06
@jeffabailey jeffabailey merged commit aef9720 into main Jul 12, 2024
2 checks passed
@jeffabailey jeffabailey deleted the governance-refactor branch July 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants