fix: bug in vobject update

InseeFr · Oct 22, 2024 · dff421b · dff421b
1 parent a7e961c
commit dff421b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/arc-web/src/main/java/fr/insee/arc/web/gui/all/util/LineObject.java b/arc-web/src/main/java/fr/insee/arc/web/gui/all/util/LineObject.java
@@ -41,4 +41,15 @@ public LineObject clone() {
     public Iterator<String> iterator() {
         return this.d.iterator();
     }
+
+    /**
+     * returns the value in cell at position pos
+     * If position is out of range, return null
+     * @param pos
+     * @return
+     */
+    public String getCell(int pos)
+    {
+    	return (pos<d.size())?d.get(pos):null;
+    }
 }
diff --git a/arc-web/src/main/java/fr/insee/arc/web/gui/all/util/VObjectService.java b/arc-web/src/main/java/fr/insee/arc/web/gui/all/util/VObjectService.java
@@ -768,7 +768,8 @@ public void update(VObject currentData) {
 				reqUpdate.append(" WHERE ");
 
 				comma = false;
-				for (int j = 0; j < currentData.getContent().get(lineToBeUpdated).d.size(); j++) {
+
+				for (int j = 0; j < v0.getContent().get(lineToBeUpdated).d.size(); j++) {
 					String label = v0.getHeadersDLabel().get(j);
 					if (nativeFieldsList.contains(label)) {
 						if (comma) {
@@ -777,6 +778,7 @@ public void update(VObject currentData) {
 						comma = true;
 
 						String oldValue = v0.getContent().get(lineToBeUpdated).d.get(j);
+
 						if (ManipString.isStringNull(oldValue)) {
 							reqUpdate.append(label + " IS NULL");
 						} else {
@@ -786,7 +788,8 @@ public void update(VObject currentData) {
 						}
 
 						// Updates value in v0
-						String newValue = currentData.getContent().get(lineToBeUpdated).d.get(j);
+						String newValue = currentData.getContent().get(lineToBeUpdated).getCell(j);
+
 						if (newValue != null) {
 							v0.getContent().get(lineToBeUpdated).d.set(j, newValue);
 						}