Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: geenralize exception handler for the operations module #851

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

EmmanuelDemey
Copy link
Collaborator

No description provided.

@EmmanuelDemey
Copy link
Collaborator Author

Je la laisse en draft. Car je n'ai pas fini

@EmmanuelDemey EmmanuelDemey marked this pull request as ready for review January 21, 2025 10:20
@EmmanuelDemey
Copy link
Collaborator Author

I also remove some IntelliJ errors. and make validation endpoint looking similar : object/:id/validate.

@EmmanuelDemey EmmanuelDemey force-pushed the feat/generalize-exception-handler branch from 0a604c6 to a4fd142 Compare January 21, 2025 10:29
@EmmanuelDemey EmmanuelDemey merged commit 43b350d into main Jan 29, 2025
1 check passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
44.9% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

}
@Parameter(description = "Concept", required = true) @RequestBody String body) throws RmesException {
conceptsService.setConcept(id, body);
logger.info("Concept updated : {}" , id);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
throw e;
}
conceptsService.setCollection(id, body);
logger.info("Update collection : {}" , id);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
throw e;
}
conceptsService.setCollectionsValidation(body);
logger.info("Validated concepts : {}" , body);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants