Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount external resources #266

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

laurentC35
Copy link
Contributor

@laurentC35 laurentC35 commented Nov 8, 2024

Entry point for Pearl-Jam is only the mount function exported by boostrap.tsx
We don't want to let Pearl-Jam decide if you have to mount externalResources.

So we adapt de mount function to load externalResources if needed.

See:

Entry point for Pearl-Jam is only the `mount` function exported by boostrap.tsx
Copy link

sonarqubecloud bot commented Nov 8, 2024

@laurentC35 laurentC35 merged commit 5dd980d into 2.3 Nov 8, 2024
9 checks passed
@laurentC35 laurentC35 deleted the fix/mount-external-resources branch November 8, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants