fix: manage all cases

InseeFr · Nov 18, 2024 · f9e4873 · f9e4873
1 parent 8e40c8d
commit f9e4873
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/eno-core/src/main/java/fr/insee/eno/core/utils/LunaticUtils.java b/eno-core/src/main/java/fr/insee/eno/core/utils/LunaticUtils.java
@@ -117,9 +117,13 @@ public static List<String> getCollectedVariablesInLoop(Loop loop) {
         List<String> result = new ArrayList<>();
         loop.getComponents().forEach(component -> {
             switch (component.getComponentType()) {
-                case CHECKBOX_BOOLEAN, INPUT_NUMBER, INPUT, TEXTAREA, DATEPICKER, DURATION, RADIO,
+                case CHECKBOX_BOOLEAN, INPUT_NUMBER, INPUT, TEXTAREA, SUGGESTER, DATEPICKER, DURATION, RADIO,
                         CHECKBOX_ONE, DROPDOWN, CHECKBOX_GROUP, TABLE ->
                         result.addAll(getDirectResponseNames(component));
+                case QUESTIONNAIRE, SEQUENCE, SUBSEQUENCE, TEXT, ACCORDION ->
+                        doNothing();
+                case QUESTION ->
+                        throw new IllegalStateException("This method does not support the question component.");
                 case ROSTER_FOR_LOOP ->
                         throw new LunaticLoopException(String.format(
                                 "Dynamic tables are forbidden in loops: loop '%s' contains a dynamic table.",
@@ -132,14 +136,15 @@ public static List<String> getCollectedVariablesInLoop(Loop loop) {
                         throw new LunaticLoopException(String.format(
                                 "Pairwise components are forbidden in loops: loop '%s' contains a pairwise component.",
                                 loop.getId()));
-                default ->
-                        throw new IllegalArgumentException(
-                                "Unexpected component type '" + component.getComponentType() + "'.");
             }
         });
         return result;
     }
 
+    private static void doNothing() {
+        /* No-op method */
+    }
+
     /**
      * Return the response name of the component that belong to the given pairwise links. This method checks if
      * the inner component is valid.