fix: duration components in resizing #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsenave
added
the
deploy-snapshot
|
des corrections à faire à la marge encore |
FBibonne
reviewed
Nov 18, 2024
eno-core/src/main/java/fr/insee/eno/core/utils/LunaticUtils.java
Outdated
Show resolved
Hide resolved
nsenave
added
deploy-snapshot
|
👋 Version 3.29.1-SNAPSHOT deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Done
Les composants de type
DURATIONétaient ignorés dans la méthode desLunaticUtilsqui va chercher la liste des réponses d'une boucle.L'erreur était silencieuse car le cas
defaultdans le switch d'une des méthodes se contentait d'unlog.debug😶NB : Les composants de type
SUGGESTERétaient ignorés aussi. On avait donc le même bug pour les suggester saisis depuis Pogues dans une boucle. Mais ça ne concerne pas les suggester créés avec un traitement spécifique (le cas le plus utilisé aujourd'hui encore j'imagine).C'est corrigé au passage.