Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/eno xml wrong zip name #1163

Merged
merged 21 commits into from
Dec 2, 2024
Merged

Fix/eno xml wrong zip name #1163

merged 21 commits into from
Dec 2, 2024

Conversation

RemiVerriez
Copy link
Contributor

  • Le endpoint {context}/fo renvoie désormais un zip qui est valide lorsque multi-model=true.

  • Méthode "sendPostRequestByte" améliorée pour permettre notamment la bonne réception des noms de fichiers (zip ou non). Les endpoints (hors Lunatic et Pogues) sont tous assignés à cette méthode désormais.

  • Amélioration de la gestion des exceptions : le body de la réponse ne renvoie plus systématiquement une erreur de type "500" à chaque erreur produite côté Eno XML. Le message et le type de l'erreur sont maintenant cohérents entre Eno XML et Eno Java.

@RemiVerriez RemiVerriez requested a review from nsenave November 22, 2024 15:27
@RemiVerriez RemiVerriez reopened this Nov 22, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.4% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@RemiVerriez RemiVerriez added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 22, 2024
@nsenave nsenave changed the base branch from v3-main to v3-next November 22, 2024 16:28
Copy link

👋 Version 3.29.2-SNAPSHOT deployed on docker hub

@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 22, 2024
Copy link
Contributor

@nsenave nsenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pas encore tout reviewed)

eno-ws/src/main/resources/application.properties Outdated Show resolved Hide resolved
@RemiVerriez RemiVerriez added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 22, 2024
Copy link

👋 Version 3.29.2-SNAPSHOT.1 deployed on docker hub

@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 22, 2024
@RemiVerriez RemiVerriez added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 26, 2024
Copy link

👋 Version 3.29.2-SNAPSHOT.2 deployed on docker hub

@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 26, 2024
@RemiVerriez RemiVerriez added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 29, 2024
Copy link

👋 Version 3.29.2-SNAPSHOT.3 deployed on docker hub

@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 29, 2024
@nsenave nsenave added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 29, 2024
Copy link

👋 Version 3.29.2-SNAPSHOT.4 deployed on docker hub

@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 29, 2024
@nsenave nsenave merged commit a77584d into v3-next Dec 2, 2024
6 checks passed
@nsenave nsenave deleted the fix/Eno-Xml-Wrong-zip-name branch December 2, 2024 08:14
nsenave pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants