feat(lunatic): format control for the year of date questions #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsenave
requested review from
laurentC35,
loichenninger,
QRuhier,
davdarras,
alexisszmundy,
RemiVerriez and
chloe-renaud
nsenave
added
the
deploy-snapshot
|
👋 Version 3.30.0-SNAPSHOT deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
nsenave
added
the
deploy-snapshot
|
👋 Version 3.30.0-SNAPSHOT.1 deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
laurentC35
requested changes
Dec 5, 2024
...re/src/main/java/fr/insee/eno/core/processing/out/steps/lunatic/LunaticAddControlFormat.java
Show resolved
Hide resolved
nsenave
added a commit
that referenced
this pull request
Dec 9, 2024
* feat(lunatic): format control for the year of date questions * refactor: some java 21+ syntax refactor * refactor: some clean up in test * chore: bump version * feat: add 'at least 4 digits' in control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cf. la user story :
À la saisie dans le composant
Datepicker:14/7/24=> la donnée est0024-07-14Le rôle du contrôle "de format" généré est de vérifier que l'année est saisie avec 4 chiffres (ici le répondant voulait sans doute dire "2024" et pas "l'an 24").
NB : rappel sur le vocabulaire métier des contrôles dans Bowie (Concevoir) :
CONSISTENCYin fine dans Lunatic)FORMATin fine dans Lunatic)Done
Ajout d'un contrôle de format VTL dans la génération Lunatic.
En VTL c'est un peu tricky (j'ai pas trouvé mieux) :
NB : la partie vraiment utile du contrôle est celle qui vérifie qu'il y a au moins 4 chiffres, mais j'ai repris la même logique "ceinture et bretelles" que pour les
InputNumber: même si le composant Lunatic bloque la saisie, le contrôle VTL vérifie le max.