refactor: dates validation and formatting #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RemiVerriez Pour la partie tests unitaires de la classe |
FBibonne
reviewed
Dec 17, 2024
eno-core/src/main/java/fr/insee/eno/core/i18n/date/Iso8601Formatter.java
Show resolved
Hide resolved
eno-core/src/main/java/fr/insee/eno/core/i18n/date/DateFormatterFactory.java
Outdated
Show resolved
Hide resolved
eno-core/src/main/java/fr/insee/eno/core/i18n/date/DateFormatter.java
Outdated
Show resolved
Hide resolved
eno-core/src/main/java/fr/insee/eno/core/i18n/date/DateFormatter.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/fr/insee/eno/core/processing/out/steps/lunatic/LunaticAddControlFormat.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/fr/insee/eno/core/processing/out/steps/lunatic/LunaticAddControlFormat.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/fr/insee/eno/core/processing/out/steps/lunatic/LunaticAddControlFormat.java
Show resolved
Hide resolved
...re/src/main/java/fr/insee/eno/core/processing/out/steps/lunatic/LunaticAddControlFormat.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/fr/insee/eno/core/processing/out/steps/lunatic/LunaticAddControlFormat.java
Outdated
Show resolved
Hide resolved
|
Merci @FBibonne pour tes retours ! J'ai fait certains refacto qu tu suggères, sur les autres points je te laisse me dire ce que tu en penses si tu repasses par ici |
nsenave
added
the
deploy-snapshot
|
👋 Version 3.30.1-SNAPSHOT.2 deployed on docker hub |
github-actions
bot
removed
the
deploy-snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai séparé la partie technique de formattage avec les aspects métier propres à Pogues/Eno.
Un peu lourd peut-être, preneur de retours