Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/v3 lunatic resizing #718

Merged
merged 13 commits into from
Sep 25, 2023
Merged

Feat/v3 lunatic resizing #718

merged 13 commits into from
Sep 25, 2023

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Sep 20, 2023

Overview

Complete implementation of Lunatic "resizing" processing for:

  • loops
  • pairwise links

Will be to do later on: roster for loop components.

Details

  • refactor: changed "resizing variable" object names to "resizing entry" which seems clearer to me
  • refactor: some minor things
  • refactor: split the resizing logic in smaller classes
  • feat: complete resizing logic for loop and pairwise components

Sooooo much code to do this 😣 the logic is (rather) simple, but many details, especially (little) Lunatic modeling flaws in many places makes it really tidious.

@nsenave nsenave self-assigned this Sep 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nsenave nsenave marked this pull request as ready for review September 21, 2023 17:17
@nsenave nsenave merged commit 10d4036 into v3-develop Sep 25, 2023
4 checks passed
@nsenave nsenave deleted the feat/v3-lunatic-resizing branch September 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants