Feat/v3 loop with except #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'except' in Pogues UI results in a filter within a loop in DDI
|
Kudos, SonarCloud Quality Gate passed!
|
nsenave
commented
Sep 26, 2023
There was a problem hiding this comment.
The handling of loop & filter objects from DDI to Lunatic is still quite complex... It is not easy find which classes are involved in the transformation of a DDI loop to a Lunatic loop.
Note to myself: write an entry in technical docs to give an overview of this (or find a refactor that would make things easy, but I don't have a neat way to do this for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#722
Context
In Pogues UI, the user can define an 'except' expression in linked loops.
It is designed to filter occurences in the linked loop, based on the answers in the main loop.
Done