Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/v3 lunatic processing paramater triggers #729

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Sep 26, 2023

#703 #704

Trigger Lunatic processing steps in function of parameters.

(Before this, parameters that activate or not certain processing steps were simply ignored.)

@nsenave nsenave self-assigned this Sep 26, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have added tests, but it is a bit tedious -> test the activation or not of some processing in larger functional tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nsenave nsenave added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Sep 26, 2023
@github-actions
Copy link

👋 Version 3.10.4-SNAPSHOT deployed on docker hub

@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Sep 26, 2023
@nsenave nsenave merged commit 4e643dd into v3-develop Sep 27, 2023
@nsenave nsenave deleted the fix/v3-lunatic-processing-paramater-triggers branch September 27, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants