Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: end question labels #774

Merged
merged 7 commits into from
Oct 26, 2023
Merged

fix: end question labels #774

merged 7 commits into from
Oct 26, 2023

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Oct 26, 2023

#723

  • Refactor "common" processing classes that insert end "comment" and "response time"
  • Add tests on resulting label of these questions
  • Add a Lunatic processing for the "response time" hours and minutes components to make these having the same page number
  • Add test on the latter

@nsenave nsenave self-assigned this Oct 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nsenave nsenave merged commit 4180fb8 into v3-next Oct 26, 2023
3 checks passed
@nsenave nsenave deleted the fix/v3-end-question-labels branch October 26, 2023 20:38
nsenave added a commit that referenced this pull request Nov 14, 2023
@nsenave
fix: end question labels (#774)
ffc055c 
* fix: end questions labels and numbering

* fix: lunatic response time questions pagination

* test: response time questions label

* test: lunatic response time questions pagination

* test: comment section label

* chore: bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nsenave nsenave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nsenave