fix: lunatic navigation in loops #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: correct vtl labels in begin and end questions * chore: bump version
* test: add unit tests for lunatic converter * test: unit test for ddi converter Unit testing from DDI is tedious... * chore: remove todo * test: add comment in lunatic mapper test
* test: failing questionnaire * fix(variables): cast after control of calculated variable * style: unnecessary import * refactor(loop scope): throw exceptions in invalid cases * test: bug should be resolved now This DDI has been generated with previous Eno legacy version. To be re-generated with the new DDI loop specification. * test: DDI with up-to-date modeling * test: add pogues source for ljr4jm9a * test: update functional test exception case * chore: bump version
* fix(controls): simplify and fix loop and filter cases * refactor: remove control property from sequences Sequence and subsequence doesn't have controls. * test(controls): controls in loops * chore: bump version * ci: tests for pull requests to v3-next
* fix(parameters): use question as lunatic pagination's default * chore: bump version * test(parameters): update test
* build: bump org.springframework.boot from 3.1.4 to 3.1.5 (#763) Bumps [org.springframework.boot](https://github.com/spring-projects/spring-boot) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.1.4...v3.1.5) --- * build: bump org.modelmapper:modelmapper from 3.1.1 to 3.2.0 (#751) Bumps [org.modelmapper:modelmapper](https://github.com/modelmapper/modelmapper) from 3.1.1 to 3.2.0. - [Changelog](https://github.com/modelmapper/modelmapper/blob/master/CHANGES.md) - [Commits](modelmapper/modelmapper@modelmapper-parent-3.1.1...modelmapper-parent-3.2.0) --- * chore: bump version --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The "Other, please specify" feature is not supported in Lunatic yet.
As Eno v2 does
* test: questionnaire with different kinds of mcq * test(mcq): integration test for ddi mapping * test(mcq): integration test for lunatic mapping * fix: complex mcq from ddi to lunatic * test(mcq): integration test for lunatic processing * test: 'l8x6fhtd', that was the trigger of all this * chore: bump version
* fix: end questions labels and numbering * fix: lunatic response time questions pagination * test: response time questions label * test: lunatic response time questions pagination * test: comment section label * chore: bump version
build(docker): change base image
* fix(security): enforce snakeyaml version * build: remove constraint on logging dependencies Desired versions are now included by the dependency management plugin * chore: bump version * style: comments and order in dependencies
* refactor: rename CleaningEntry class and add javadoc * fix(suggester): exclude externals from cleaning * test(cleaning): update tests * test(cleaning): add unit test with external * chore: bump version
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
nsenave
added a commit
that referenced
this pull request
Nov 25, 2023
- fix: insert subsequence components in loops - refactor: LunaticPaginationMode in LunaticParameters class - test: add unit and functional tests on the Lunatic pagination feature - docs: comment about max page for non paginated loops - style: fix typos here and there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Questions that belong to a subsequence were not inserted in loops by the "lunatic loop processing".
Linked issues:
Done