Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/v3 deserializer #122

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix/v3 deserializer #122

merged 2 commits into from
Nov 17, 2023

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Nov 17, 2023

Summary

Some custom serializers were added for:

  • "sym links"
  • "synonyms" and "rules" of suggester fields

Yet deserialization of a compliant json input for these properties wasn't possible yet.

Done

  • add deserializer for FieldRule
  • add deserializer for SymLinksType
  • simplify modeling of synonyms (using a map instead of defined objects, drawback: less meaningful modeling, advantage: no custom serializer and deserializer)
  • add tests relative to serialization/deserialization

@nsenave nsenave self-assigned this Nov 17, 2023
@nsenave nsenave requested a review from laurentC35 November 17, 2023 15:00
Copy link

👋 Version 3.2.5-SNAPSHOT deployed on maven central repository

@nsenave nsenave merged commit d91ccc2 into dev-eno-v3 Nov 17, 2023
7 checks passed
@nsenave nsenave deleted the fix/v3-deserializer branch November 17, 2023 17:23
nsenave added a commit that referenced this pull request Nov 23, 2023
Deserialization of "symLinks", "rules" and "synonyms"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant