Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit objects in body cells #275

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: unit objects in body cells #275

merged 1 commit into from
Dec 12, 2024

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Dec 12, 2024

Ajout/correctif suite à :

@alicela @loichenninger @alexisszmundy Je sais pas si vous lisez cette info dans les questionnaires Lunatic mais le cas échéant ça peut vous intéresser.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@nsenave nsenave merged commit d0d1742 into v3-main Dec 12, 2024
2 of 3 checks passed
@nsenave nsenave deleted the fix/unit-in-table-cells branch December 12, 2024 16:07
@nsenave
Copy link
Contributor Author

nsenave commented Dec 12, 2024

Sonar râle pour de la duplication sur des getters/setters, j'aimerais bien avoir du polymorphisme et mettre directement les composants du style InputNumber dans le body des Table / RosterForLoop, mais un peu trop coûteux à faire pour l'instant

Copy link
Contributor

@davdarras davdarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants