Feat extend identification configuration #203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davdarras
previously approved these changes
Dec 18, 2024
| @@ -303,7 +293,7 @@ private void updateAddress(SurveyUnit surveyUnit, SurveyUnitUpdateDto surveyUnit | |||
| @Transactional | |||
| public HttpStatus updateSurveyUnitViewed(String userId, String suId) { | |||
There was a problem hiding this comment.
throw exception maybe ? returning an http status doesn't feel right here
| * @param identificationDB identification DB entity | ||
| * @return the model object of the db entity | ||
| */ | ||
| public static Identification toModel(IdentificationDB identificationDB) { | ||
| if(identificationDB == null) { | ||
| if (identificationDB == null) { |
| @@ -155,7 +154,7 @@ private ResultMatcher expectTimestampFromCurrentDate(String expression, int unit | |||
| * Test that the GET endpoint "api/user" | |||
| * return 200 | |||
| * | |||
| * @throws Exception | |||
| * @throws Exception e | |||
| */ | |||
| @Test | |||
| @Order(1) | |||
There was a problem hiding this comment.
maybe we should
- get rid of orders
- have scripts to reinit database content used when updates are done
- use test containers
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.