tests: refactor tests with authentication #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davdarras
reviewed
Jul 8, 2024
|
|
||
| for (String role : listRoles) { | ||
| this.grantedRoles.put(role, | ||
| new SimpleGrantedAuthority(roleEnum.securityRole())); |
There was a problem hiding this comment.
what if same config role for multiple app roles ?
| @@ -30,9 +29,6 @@ | |||
| import java.util.List; | |||
|
|
|||
| @RestController | |||
| @PreAuthorize("@AuthorizeMethodDecider.isInternalUser() " | |||
There was a problem hiding this comment.
normal to not have preauthorize in new version ?
| @@ -98,9 +97,6 @@ public ResponseEntity<?> getQuestioningsBySurveyUnit(@PathVariable("id") String | |||
|
|
|||
| } | |||
|
|
|||
| @PreAuthorize("@AuthorizeMethodDecider.isInternalUser() " | |||
There was a problem hiding this comment.
no preauthorize in new version ?
There was a problem hiding this comment.
@PreAuthorize(AuthorityPrivileges.HAS_MANAGEMENT_PRIVILEGES) already on top of controller
|
BettyB979
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: wip: add orbeon endpoint to get questioning informations * feat: add missing fields ans change address dto * feat: add endpoint for weblient orbeon to get questioning informations * tests: dd unit tests for QuestioningInformationsService * fix: validation and habilitations for endpoint orbeon * feat: reviewer or interviewer informations (main contact or not) * fix: role check * fix: sonar issues * fix: sonar issues * fix: remove double test * tests: refactor tests with authentication and add cucumber first test (#76) * tests: add cucumber config and first tests * fix: prepare security roles * test: try authentication * fix: athority privileges and authentication context * fix: tests with authentification * fix: add preauthorize * fix: same config role for multiple app roles --------- Co-authored-by: davdarras <[email protected]> * fix: authentication name case insensitive * fix: moog test (add authentication) --------- Co-authored-by: davdarras <[email protected]>
BettyB979
added a commit
that referenced
this pull request
Aug 6, 2024
* Feat: add orbeon endpoint to get questioning informations (#73) * feat: wip: add orbeon endpoint to get questioning informations * feat: add missing fields ans change address dto * feat: add endpoint for weblient orbeon to get questioning informations * tests: dd unit tests for QuestioningInformationsService * fix: validation and habilitations for endpoint orbeon * feat: reviewer or interviewer informations (main contact or not) * fix: role check * fix: sonar issues * fix: sonar issues * fix: remove double test * tests: refactor tests with authentication and add cucumber first test (#76) * tests: add cucumber config and first tests * fix: prepare security roles * test: try authentication * fix: athority privileges and authentication context * fix: tests with authentification * fix: add preauthorize * fix: same config role for multiple app roles --------- Co-authored-by: davdarras <[email protected]> * fix: authentication name case insensitive * fix: moog test (add authentication) --------- Co-authored-by: davdarras <[email protected]> * feat: improve search contact for new pilotage front (#79) * feat: search contact with one parameter * fix: param not required in search contact * chore(deps): update versions * Update ContactRepository.java * fix: search contact with contains * feat: add second phone number * fix(tests): reinit conext for tests * fix: improve search contact (#81) * fix: improve search contact endpoint * fix: null param in search contact * fix: improve search request * fix: request find by name * test: fix tests * chore: update dependencies and bump version 2.5.0 --------- Co-authored-by: davdarras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.