-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat impl settings page #77
base: develop
Are you sure you want to change the base?
Conversation
feat - aliment user datas
sx={{ | ||
lineHeight: "24px", | ||
fontSize: "16px", | ||
letterSpacing: "0.15px", | ||
fontWeight: 400, | ||
fontFamily: "Roboto", | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On évite le style au maximum dans les composant, tu peux utiliser typography
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
responses: { get: APISchemas["ContactFirstLoginDto"]; put: APISchemas["ContactDto"]; delete: null } | ||
responses: { get: null; put: APISchemas["ContactDto"]; delete: null } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La réponse du get m'étonne
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arf, c'est à nouveau le modéle openapi qui met du null. Tu avais remplacé avec du ContactFirstLoginDto à la mano...ennuyeux de devoir reprendre à chaque mise à jour des types/api..je corrigerai l'api en retour de congés
@@ -779,7 +789,7 @@ export type APISchemas = { | |||
empty?: boolean | |||
} | |||
ContactFirstLoginDto: { | |||
identifier: string | |||
identifier?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
identifier is required
fontWeight: 600, | ||
lineHeight: "18px", | ||
letterSpacing: "0.1px", | ||
fontSize: "14px", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essaie d'utiliser une typography déjà existante
robotoLarge: { | ||
lineHeight: "24px", | ||
fontSize: "16px", | ||
letterSpacing: "0.15px", | ||
fontWeight: 400, | ||
fontFamily: "Roboto", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A retirer
No description provided.