Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat impl settings page #77

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Conversation

EricThuaud
Copy link
Contributor

No description provided.

@EricThuaud EricThuaud marked this pull request as draft February 19, 2024 15:39
Comment on lines 55 to 61
sx={{
lineHeight: "24px",
fontSize: "16px",
letterSpacing: "0.15px",
fontWeight: 400,
fontFamily: "Roboto",
}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On évite le style au maximum dans les composant, tu peux utiliser typography

@EricThuaud EricThuaud requested a review from Grafikart February 26, 2024 15:37
@EricThuaud EricThuaud marked this pull request as ready for review February 26, 2024 16:46
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Comment on lines -1110 to +1120
responses: { get: APISchemas["ContactFirstLoginDto"]; put: APISchemas["ContactDto"]; delete: null }
responses: { get: null; put: APISchemas["ContactDto"]; delete: null }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La réponse du get m'étonne

Copy link
Contributor Author

@EricThuaud EricThuaud Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arf, c'est à nouveau le modéle openapi qui met du null. Tu avais remplacé avec du ContactFirstLoginDto à la mano...ennuyeux de devoir reprendre à chaque mise à jour des types/api..je corrigerai l'api en retour de congés

@@ -779,7 +789,7 @@ export type APISchemas = {
empty?: boolean
}
ContactFirstLoginDto: {
identifier: string
identifier?: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identifier is required

Comment on lines +417 to +420
fontWeight: 600,
lineHeight: "18px",
letterSpacing: "0.1px",
fontSize: "14px",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essaie d'utiliser une typography déjà existante

Comment on lines +217 to +223
robotoLarge: {
lineHeight: "24px",
fontSize: "16px",
letterSpacing: "0.15px",
fontWeight: 400,
fontFamily: "Roboto",
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A retirer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants