Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic unit on input number #803

Merged
merged 12 commits into from
Dec 18, 2024
Merged

feat: dynamic unit on input number #803

merged 12 commits into from
Dec 18, 2024

Conversation

QRuhier
Copy link
Contributor

@QRuhier QRuhier commented Sep 11, 2024

@QRuhier QRuhier changed the title feat: dynamic unit feat: dynamic unit on input number Sep 11, 2024
@@ -521,10 +521,18 @@ const dictionary = {
en: 'Please respect the date format',
fr: 'Merci de respecter le format de la date',
},
dynamicUnit: {
en: 'Custom unit of measure',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customized unit of measurement

unit: {
en: 'Unit of measure',
fr: 'Unité de mesure',
},
dynamicUnitFormula: {
en: 'Formula of the unit of measure',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit of measurement formula

src/model/transformations/response.spec.jsx Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
31.4% Coverage on New Code (required ≥ 50%)
10.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@QRuhier QRuhier merged commit 7c75d6f into 1.7 Dec 18, 2024
7 of 8 checks passed
@QRuhier QRuhier deleted the feat/dynamic-unit branch December 18, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants