Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init and use react-intl #104

Merged
merged 4 commits into from
Apr 12, 2024
Merged

init and use react-intl #104

merged 4 commits into from
Apr 12, 2024

Conversation

RenauxLeaInsee
Copy link
Contributor

No description provided.

@RenauxLeaInsee RenauxLeaInsee self-assigned this Apr 11, 2024
@RenauxLeaInsee RenauxLeaInsee marked this pull request as ready for review April 11, 2024 11:06
Copy link
Contributor

@MickaelMenet MickaelMenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voir commentaires.

src/i18n-en.js Outdated
goToReadPage: 'Read' ,
goToClosePage: 'Close' ,
goToNotifyPage: 'Notify' ,
goToCollectOrganization: 'Collect Organization',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai un doute sur la traduction de Collect Organization

@@ -18,7 +18,8 @@
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noFallthroughCasesInSwitch": true
"noFallthroughCasesInSwitch": true,
"allowJs": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utile finalement ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui il y en a besoin pour les imports des fichiers i18n-en et i18n-fr

Copy link

@RenauxLeaInsee RenauxLeaInsee merged commit 5cd8d4b into sonorV2 Apr 12, 2024
8 checks passed
@RenauxLeaInsee RenauxLeaInsee deleted the init/React-intl branch April 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants