Chore : Refactor Header.tsx #390
Open
+85
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
ddecrulle
reviewed
Sep 11, 2023
Comment on lines
+16
to
+19
| const brandTop = header?.brandTop ?? DEFAULT_HEADER.brandTop; | ||
| const homeLinkProps = header?.homeLinkProps ?? DEFAULT_HEADER.homeLinkProps; | ||
| const serviceTitle = header?.serviceTitle ?? DEFAULT_HEADER.serviceTitle; | ||
| const operatorLogo = header?.operatorLogo ?? DEFAULT_HEADER.operatorLogo; |
There was a problem hiding this comment.
Maybe it will clearer to extract this into function that will take header and return brandTop, homeLinkProps ...
| ); | ||
| })} | ||
| {quickAccessItems.map((item, index) => ( | ||
| <QuickAccessLi key={index} item={item} /> |
There was a problem hiding this comment.
use index as key could cause trouble, use an id
| ); | ||
| })} | ||
| {quickAccessItems.map((item, index) => ( | ||
| <QuickAccessLi key={index} item={item} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of Header to avoid unecessary rerenders and to solidify the logic behind quick access item