[BUG] 🐛 Hotfix connection pooling created though already exists decor…

…ator Signed-off-by: Antoine Brunetti <[email protected]>
InseeFr · Nov 17, 2023 · 2881589 · 2881589
1 parent 1e28669
commit 2881589
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/sugoi-api-seealso-ldap/src/main/java/fr/insee/sugoi/seealso/LdapSeeAlsoDecorator.java b/sugoi-api-seealso-ldap/src/main/java/fr/insee/sugoi/seealso/LdapSeeAlsoDecorator.java
@@ -84,7 +84,9 @@ private Object transformLdapResponseToValue(
   }
 
   private LDAPConnectionPool getConnectionByHost(String host, int port) throws LDAPException {
-    ldapConnectionByHost.putIfAbsent(host + "_" + port, createHostConnection(host, port));
+    if (!ldapConnectionByHost.containsKey(host + "_" + port)) {
+      ldapConnectionByHost.put(host + "_" + port, createHostConnection(host, port));
+    }
     return ldapConnectionByHost.get(host + "_" + port);
   }
 

diff --git a/...seealso-ldap/src/test/java/fr/insee/sugoi/seealso/LdapSeeAlsoDecoratorBadAuthentTest.java b/...seealso-ldap/src/test/java/fr/insee/sugoi/seealso/LdapSeeAlsoDecoratorBadAuthentTest.java
@@ -39,7 +39,7 @@ public class LdapSeeAlsoDecoratorBadAuthentTest {
   public void requestWithBadCredentialsShouldFail() {
     Object res =
         ldapSeeAlsoDecorator.getResourceFromUrl(
-            "ldap://localhost:10389/uid=testc,ou=contacts,ou=clients_domaine1,o=insee,c=fr", "cn");
+            "ldap://localhost:10389/uid=testc,ou=contacts,ou=clients_domaine2,o=insee,c=fr", "cn");
     assertThat("Resource should be null", res, is(nullValue()));
   }
 }