Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.22 and minor refactors #48

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Update to Go 1.22 and minor refactors #48

merged 7 commits into from
Aug 13, 2024

Conversation

phlg
Copy link
Contributor

@phlg phlg commented Aug 8, 2024

There's still a couple of TODO's in the branch code, one of which I can clear soon. Until then, please leave as draft and don't merge the PR.

For the rest, here's a barebones patch note :

  • Update to Go 1.22
    • which allows using cmp.Or to save some lines when deciding whether to use a user's metadata.name or spec.secretName to
  • Added some 8-characters long names to the loggers when there weren't any, to have more uniform logs (eg : see .WithName("bcktCtrl"))
  • Turned some functions into methods to remove some unnecessary arguments
  • Renamed some functions in the S3User controller to clarify the logic
  • Reworked (and added some additional checks) in minioS3Client.go to better manage errors
  • Changes to the various statuses used in the S3User controller
  • Minor rewording for some log and status condition messages.

@phlg phlg requested a review from JackLemaitre August 8, 2024 16:08
@phlg phlg marked this pull request as ready for review August 13, 2024 08:23
@phlg phlg merged commit 4f1fbf3 into main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants