BUG: TubeTK STATIC, even if itkTubeTK SHARED #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itkTubeTK is a two-library system: 1) The include directory contains the itkTubeTK library which depends on the TubeTK library. The itkTubeTK library is a high-quality ITK interface (that can be wrapped for python) to the TubeTK library. 2) The src directory contains the TubeTK library which is an (ancient) mix of ITK and non-ITK classes, functions, applications, and examples. It is poorly documented and inconsistent in style, but it is rich in functionality :) Regretfully the old TubeTK does not support being built as a shared library. So, even if itkTubeTK is being built shared, the underlying TubeTK library will always be built static.
thewtex
approved these changes
Jun 28, 2024
itkTubeTK is a two-library system: 1) The include directory contains the itkTubeTK library which depends on the TubeTK library. The itkTubeTK library is a high-quality ITK interface (that can be wrapped for python) to the TubeTK library. 2) The src directory contains the TubeTK library which is an (ancient) mix of ITK and non-ITK classes, functions, applications, and examples. It is poorly documented and inconsistent in style, but it is rich in functionality :) Regretfully the old TubeTK does not support being built as a shared library. So, even if itkTubeTK is being built shared, the underlying TubeTK library will always be built static.
aylward
merged commit 5513ca8
into
InsightSoftwareConsortium:master
23 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itkTubeTK is a two-library system:
The include directory contains the itkTubeTK library which depends on the TubeTK library. The itkTubeTK library is a high-quality (or perhaps we should say constantly improving) ITK interface to the TubeTK library (e.g., it is a compliant ITK module, supports wrapping, etc.).
The src directory contains the TubeTK library which is an (ancient) mix of ITK and non-ITK classes, functions, applications, and
examples. It is poorly documented and inconsistent in style, but it is (arguably, for some users) rich in functionality. :)
Regretfully the old TubeTK library in src does not support being built as a shared library. So, even if itkTubeTK is being built shared, the underlying TubeTK library will always be built static.