Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace typing.List and other aliases w/ builtin equivalents after Python 3.10 #496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yangdanny97
Copy link

@yangdanny97 yangdanny97 commented Nov 18, 2024

Summary

This is the inverse of UseTypesFromTyping https://github.com/Instagram/Fixit/blob/main/src/fixit/rules/use_types_from_typing.py

In Python versions after 3.10, we can replace typing.List and other aliases with the builtin equivalents.

Test Plan

make

closes #482

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024
@yangdanny97
Copy link
Author

Oh, I just realized this is almost a duplicate of #482

This one adds typing.Type support which the other one doesn't have, but I'll let the maintainers decide which to move forward with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants