Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop codecov from CI and readme #1192

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Drop codecov from CI and readme #1192

merged 2 commits into from
Aug 22, 2024

Conversation

amyreese
Copy link
Member

Summary

Codecov keeps failing in CI. Chatted with @zsol and it doesn't seem worth the effort.

Test Plan

CI should actually pass.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2024
@amyreese amyreese requested a review from zsol August 21, 2024 23:19
zsol
zsol approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@amyreese amyreese merged commit a4203e5 into Instagram:main Aug 22, 2024
20 checks passed
@amyreese amyreese deleted the codecov branch August 22, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol zsol approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyreese @zsol @facebook-github-bot