Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip musllinux builds for unsupported archs #1244

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

MrMino
Copy link
Contributor

@MrMino MrMino commented Nov 17, 2024

See #1243. CI started failing after pulling that change into main.

Summary

This fixes current CI failures by skipping Musl builds for i686, ppc64le, s390x, and armv7le architectures.

The failures are due to Rust ecosystem having only partial support / not having tool chains for these architectures. For the list of supported archs and tiers of support, see:

https://doc.rust-lang.org/nightly/rustc/platform-support.html

The architectures skipped here are either, from the Rust PoV:

  • Tier-2 support without host tools.
  • Tier-3 support without host tools.

This fixes current CI failures by skipping Musl builds for `i686`,
`ppc64le`, `s390x`, and `armv7le` architectures.

The failures are due to Rust ecosystem having only partial support / not
having tool chains for these architectures. For the list of supported
archs and tiers of support, see:

https://doc.rust-lang.org/nightly/rustc/platform-support.html

The architectures skipped here are either, from the Rust PoV:

- Tier-2 support without host tools.
- Tier-3 support without host tools.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2024
@MrMino
Copy link
Contributor Author

MrMino commented Nov 17, 2024

FTR I'm still waiting for the build to pass on my fork repo, to see if I haven't fatfingered any of the CIBW_SKIP patterns.

@MrMino
Copy link
Contributor Author

MrMino commented Nov 17, 2024

For some reason cibuildwheel is still trying to set up a musllinux_1_2_i686 environment... This needs further fixing.

@MrMino MrMino marked this pull request as draft November 17, 2024 16:22
@MrMino
Copy link
Contributor Author

MrMino commented Nov 17, 2024

Correction: turns out the GHAs in my fork were still using the upstream's build.yml file, so the failure I saw was actually a false positive - it just didn't use the changes I made here.

This is ready to be merged. Passing build jobs:

Kind nudge @zsol :)

@MrMino MrMino marked this pull request as ready for review November 17, 2024 17:12
@zsol zsol merged commit 4ff38c0 into Instagram:main Nov 17, 2024
23 checks passed
@zsol
Copy link
Member

zsol commented Nov 17, 2024

Nice, thanks for following up :)

@MrMino MrMino deleted the unsupported_musl_arch branch November 17, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants