Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for composite devices #1993

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

ndgrigorian
Copy link
Collaborator

This PR proposes supporting the oneAPI composite devices extension in dpctl, which exposes multi-tile GPU devices as root devices for each tile, but also provides access to the composite devices from level zero prior to ZE_FLAT_DEVICE_HIERARCHY=FLAT becoming the default. i.e., with ZE_FLAT_DEVICE_HIERARCHY=COMPOSITE, the composite devices are root devices, but with ZE_FLAT_DEVICE_HIERARCHY=COMBINED, a user gains access to these composite devices through dedicated APIs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

Copy link

Array API standard conformance tests for dpctl= ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2025

Coverage Status

coverage: 87.379% (-0.9%) from 88.233%
when pulling 76f2fc2 on support-composite-devices
into 7e2b69e on master.

@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from ddc5f50 to 2d5942d Compare February 18, 2025 23:49
Also removes some remaining, sporadic references to the deprecated sycl::info::device_type::host
These device types act unexpectedly in DPC++ 2025.0.4, returning the same result as `sycl::info::device_type::all`, so use unknown device and return an empty list instead
This leverages oneAPI extension for composite devices to add the free function `ext_oneapi_get_composite_devices` to the main dpctl namespace
This method is only applicable for level_zero backend, returning an empty list for all other backend types
@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from 2d5942d to 76f2fc2 Compare February 21, 2025 20:55
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_544 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants