Skip to content

Disable w/a for dpctl-2030 on CPU device #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Disable w/a for dpctl-2030 on CPU device #2405

merged 1 commit into from
Apr 2, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 2, 2025 •
edited
Loading

The PR proposes to partly merge changes from #2403 to unblock coverage GitHub action.
The workaround for dpctl-2030 was kept only for testing with GPU device (the use case from internal CI, where the changes from dpctl-2030 is not available).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Apr 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_65 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

vtavana
vtavana approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 434156d into master Apr 2, 2025
67 checks passed
@antonwolfy antonwolfy deleted the partly-remove-w/a-dpctl-2030 branch April 2, 2025 12:02
github-actions bot added a commit that referenced this pull request Apr 2, 2025
@github-actions
Disable w/a for dpctl-2030 on CPU device (#2405)
0214627 
The PR proposes to partly merge changes from #2403 to unblock coverage
GitHub action.
The workaround for dpctl-2030 was kept only for testing with GPU device
(the use case from internal CI, where the changes from dpctl-2030 is not
available). 434156d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana