Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pre-commit hooks #142

Merged
merged 3 commits into from
Apr 1, 2025
Merged

add pre-commit hooks #142

merged 3 commits into from
Apr 1, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 31, 2025 •
edited
Loading

add pre-commit formatting configuration,

pylint hook is added with "--errors-only" otherwise it suggests a lot of changes which should to be addressed separately, if needed.

@vtavana vtavana self-assigned this Mar 31, 2025
@vtavana vtavana marked this pull request as ready for review March 31, 2025 21:00
ndgrigorian
ndgrigorian reviewed Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! I think it would be good to add a .git-blame-ignore-revs file too, though

ndgrigorian
ndgrigorian reviewed Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, a workflow for pre-commit would align with the other projects

It would be a good idea to make similar changes in umath and random, as well as the migration to pyproject.toml

Maybe issues should be made for these things

This was referenced Mar 31, 2025
Open
Open
antonwolfy
antonwolfy previously approved these changes Apr 1, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed Apr 1, 2025
View reviewed changes
@vtavana vtavana force-pushed the add-pre-commit branch 2 times, most recently from 47513b5 to 5efbeff Compare April 1, 2025 16:04
@vtavana vtavana mentioned this pull request Apr 1, 2025
Closed
@vtavana vtavana force-pushed the add-pre-commit branch 4 times, most recently from eed768e to 1bdc21e Compare April 1, 2025 16:39
ndgrigorian
ndgrigorian reviewed Apr 1, 2025
View reviewed changes
ndgrigorian
ndgrigorian approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more from me, I think this looks good, thanks for your work on this @vtavana

antonwolfy
antonwolfy approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit bee4cf6 into master Apr 1, 2025
41 checks passed
@vtavana vtavana deleted the add-pre-commit branch April 1, 2025 19:06
@vtavana vtavana changed the title add pre-commit format add pre-commit hooks Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy antonwolfy approved these changes

@xaleryb xaleryb Awaiting requested review from xaleryb xaleryb is a code owner

@ekomarova ekomarova Awaiting requested review from ekomarova ekomarova is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @ndgrigorian @antonwolfy