This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Scale quantile via DAAL #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @PokhodenkoSA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
@PokhodenkoSA to control number of threads use this |
sdc/_daal.cpp
Outdated
| using namespace daal::algorithms; | ||
| using namespace daal::data_management; | ||
|
|
||
| quantiles::Batch<> algorithm; |
There was a problem hiding this comment.
You should specify the data type of algorithm as a template parameter and provide data with the same type. Default type is used now but it is not clear what this type is. If you will provide the double data to the float algorithm then time will be spent on converting and copying.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for discussion. It shows how to pass NumPy array to C++ module.
Also it shows that using ctypes functions is more convenient than
ll.add_symbol()like in #631 b/c function could be run in Python too.Numba/Numpy:
DAAL:
