Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build DQT with visual studio 2017 #12248

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix build DQT with visual studio 2017 #12248

merged 2 commits into from
Oct 9, 2023

Conversation

Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented Oct 2, 2023

Tracked on [RSDEV-602]

@Tamir91 Tamir91 requested a review from OhadMeir October 2, 2023 12:04
OhadMeir
OhadMeir approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 8, 2023

@Tamir91 does GTH has a runner that runs VS 2017?

@Nir-Az Nir-Az merged commit bf03775 into IntelRealSense:development Oct 9, 2023
@Tamir91
Copy link
Contributor Author

Tamir91 commented Oct 10, 2023 •
edited
Loading

@Tamir91 does GTH has a runner that runs VS 2017?

Hi Nir.
I found that exist option to do it. Moreover I already created test for it but my script build VS 2019 and not VS 2017 as wrote in script. I need understand why it happens.

@Tamir91 Tamir91 changed the title include added Fix build DQT with visual studio 2017 Oct 10, 2023
@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 10, 2023

Maybe this is why Visual Studio 17 2022

cmake ${LRS_SRC_DIR} -G "Visual Studio 17 2022" -DBUILD_SHARED_LIBS=true -DBUILD_EXAMPLES=false -DBUILD_TOOLS=false -DCHECK_FOR_UPDATES=false

@Tamir91
Copy link
Contributor Author

Tamir91 commented Oct 10, 2023

Maybe this is why Visual Studio 17 2022

cmake ${LRS_SRC_DIR} -G "Visual Studio 17 2022" -DBUILD_SHARED_LIBS=true -DBUILD_EXAMPLES=false -DBUILD_TOOLS=false -DCHECK_FOR_UPDATES=false

I not sure that this is a reason. See my early code:
There I wrote vs-version: '15.9' but in a log I see C:\Program Files\Microsoft Visual Studio\2022\Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tamir91 @Nir-Az @OhadMeir