Fix D457 RGB sensor exposure control range issue #12251
Conversation
| query.id = get_cid(option); | ||
| if (xioctl(_fd, VIDIOC_QUERYCTRL, &query) < 0) | ||
| if (xioctl(_fd, VIDIOC_QUERY_EXT_CTRL, &query) < 0) |
There was a problem hiding this comment.
Will this affect other controls as well?
Does this means this comment will be no longer relevant?
// Some controls (exposure, auto exposure, auto hue) do not seem to work on V4L2
// Instead of throwing an error, return an empty range. This will cause this control to be omitted on our UI sample.
// TODO: Figure out what can be done about these options and make this work
|
@dmipx can you please review this ? |
|
Closed and reopened to trigger CI |
|
@hsuys Verified on JP4, Any explanation to why it works? :) |
|
I can confirm that this change still works for LRS 2.55.1 on JP5.0.2 and v1.0.1.21 driver with D457 mipi camera. Sorry, I couldn't really explain why this would work except that the same control was used for get_xu_range() |
|
@hsuys since we cannot explain why it works I recommend minimize the change and to only change the mipi get_pu_range function to use it, instead if the main uvc function. |
|
@Nir-Az, I agree. This fix should be for mipi sku to minimize the impact. |
…realsense into fix_d457_rgb_exp_range
fix d457 rgb sensor exposure ctrl range issue
changes:
change to VIDIOC_QUERY_EXT_CTRL instead of VIDIOC_QUERYCTRL when calling ioctls
Tracked on: RSDSO-19295