Setting preset does not update color options for D500 #12272
Conversation
| # License: Apache 2.0. See LICENSE file in root directory. | ||
| # Copyright(c) 2023 Intel Corporation. All Rights Reserved. | ||
|
|
||
| # test:donotrun:gha |
There was a problem hiding this comment.
What does it means?
Where would this test run?
Aren't we missing
#device d400*
#device D500*? (not sure it will work)
There was a problem hiding this comment.
Beside that question, great test!!
There was a problem hiding this comment.
I checked,
LibCI: -D- test-live-options-presets is not live; skipping
GHA - -D- test-live-options-presets is marked do-not-run; skipping
GHA is not running live tests IMO.
You should add the matching #device keywords
| # License: Apache 2.0. See LICENSE file in root directory. | ||
| # Copyright(c) 2023 Intel Corporation. All Rights Reserved. | ||
|
|
||
| # test:device each(D400*) each(D500*) |
There was a problem hiding this comment.
This might not work for 2 reasons.
- not sure this syntax is supported, let's see
Normally I know we do:
#test:device each(D400*)
#test:device each(D500*)
- Not sure D500* will work, I think since we do not have D500 discovered LibCI might fail
If it happened, we need to remove it here and add it in another PR elsewere
There was a problem hiding this comment.
I will delete D500 for now.
I know we don't have D500 yet on LibCI but we will have soon. We will need to think on a solution to all the tests, adding D500 to all seems to much.
There were 2 design options:
device_interfaceand each concrete device type will implement if color options need setting.advanced_modedeciding based on device type. Might need to updateadvanced_modemodule for future devices.I selected option number 2.