Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all ExternalProjectTargets into '3rd Party' #12331

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Oct 29, 2023

Today we have some projects, like GLFW3, outside any hierarchy in Visual Studio.
Others are in "ExternalProjectTargets", which isn't nice-looking.

This moves everything into 3rd Party

Tracked on [LRS-939]

@maloel maloel requested a review from Nir-Az October 29, 2023 08:13
@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 29, 2023

Please make sure release flow work before we merge this

@maloel
Copy link
Collaborator Author

maloel commented Oct 29, 2023

Please make sure release flow work before we merge this

This is just the Visual Studio organization... no effect on the build...
But OK, I'll run the release flow.

@maloel
Copy link
Collaborator Author

maloel commented Oct 29, 2023

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 851aed5 into IntelRealSense:development Oct 29, 2023
16 checks passed
@maloel maloel deleted the 3rd-party branch October 29, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants