Fps permutations test #12335
Fps permutations test #12335
Conversation
|
@AviaAv always check if your test indeed run in all required OS. |
|
Please rebase development and run CI manually with nightly context and verify the test run and pass on all supported OS's |
| f"{sensor_profile_dict[sensor_key][0].stream_name()} is {expected_fps_dict[sensor_key]}" | ||
| f" on {get_resolution(sensor_profile_dict[sensor_key][0])}\n") | ||
| s = s.replace("on (0, 0)", "") # remove no resolution for Motion Module profiles | ||
| s += "***************" |
There was a problem hiding this comment.
Remove. Might be helpful for debug but we don't want this in the final logs
| funcs_dict = generate_functions(sensor_fps_dict) | ||
|
|
||
| for key in sensor_profiles_dict: | ||
| sensor = key |
There was a problem hiding this comment.
Just use for sensor in ...
| sensor_fps_dict[key] /= TIME_TO_COUNT_FRAMES | ||
| # now for each sensor we have the average fps received | ||
|
|
||
| sensor = key |
| ############################################# | ||
| # ---------- Core Test Functions ---------- # | ||
| ############################################# | ||
| def check_fps(expected_fps, fps_measured): |
There was a problem hiding this comment.
Rename check_fps_dict. Also it is better to have measured fps as the first argument for consistency with our other check functions use (and also your own check_fps_pair).
| # to avoid having a long run time, we don't choose the same stream more than once | ||
| if p.stream_type() not in stream_types_added: | ||
| if p.stream_type() == rs.stream.infrared: | ||
| if p.stream_index() != 1: |
There was a problem hiding this comment.
Style comment (decide if you want to change) - this is very indented you can use and instead of the last if, or better yet, move the last 3 ifs to a function should_add_profile
| if p.stream_type() not in stream_types_added: | ||
| if p.stream_type() == rs.stream.infrared: | ||
| if p.stream_index() != 1: | ||
| continue # on some devices, using Infrared 1 seems to have better fps than IR/IR2 |
There was a problem hiding this comment.
The comment is not clear - which models and why...
According to our talk with Idan you can use validation KPIs are for depth+IR1 not IR2
AviaAv
force-pushed
the
fps-perm-test
branch
from
ca25baf to
721218f
Compare
AviaAv
force-pushed
the
fps-perm-test
branch
2 times, most recently
from
e159742 to
e35a008
Compare
Tracked on [LRS-909]