fix dds metadata timestamp to be in ms #12755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Mar 17, 2024
| @@ -274,7 +274,7 @@ void dds_sensor_proxy::handle_video_data( realdds::topics::image_msg && dds_fram | |||
| { | |||
| frame_additional_data data; // with NO metadata by default! | |||
| data.timestamp // in ms | |||
| = static_cast< rs2_time_t >( realdds::time_to_double( dds_frame.timestamp ) * 1e3 ); | |||
| = static_cast< rs2_time_t >( realdds::time_to_double( dds_frame.timestamp ) * 1e6 ); | |||
There was a problem hiding this comment.
I think we test the timestamp in the unit test. How did it pass so far?
https://github.com/IntelRealSense/librealsense/blob/development/unit-tests/dds/test-metadata.py#L194
|
Closing as root cause is unknown and solution in doubt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
f.get_frame_metadata(rs.frame_metadata_value.frame_timestamp):Under DDS mode, LibRS metadata hw timestamp is Nanosecond (ns).
939660614000
939693958000
However, under USB mode, hw timestamp is Microsecond (us).
319109940
319143273
rs2_time_tis supposed to be in milli, so it looks like the conversion we made was off by 1000 and stored as micro.Tracked on [RSDEV-1805]