Size & CRC in dfu-start; topic-reader stop-from-callback crashes #12789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size and CRC are currently not an input.
FW size is not known in advance.
5e needs to know how much memory to allocate before reading from the
dfu
topic, so the size needs to be communicated in advance for the allocation.The CRC was added as well, to aid in validating that the blob was received intact.
dds_topic_reader
to useshared_from_this()
to keep the object alive; made_stopped
a shared_ptr to share ownershipI also simplified the DDS tests a bit.
Tracked on [RSDEV-1869]