power line freq option with hardcoded range #12813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Apr 1, 2024
src/ds/d500/d500-options.h
Outdated
| { | ||
| // this range had to be harcoded to avoid collisions with linux patches | ||
| // which have been upstreamed for d400 devices | ||
| return { 0.f /*min*/, 2.f /*max*/, 1.f /*step*/, 0.f /*default*/ }; |
There was a problem hiding this comment.
Is it possible to make it a lazy when we query the range from PU and only override the min/max?
I think it will be better since each camera can have a different default, here we are forcing it.
Thoughts?
Nir-Az
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-1777