Fix FW logs bug. #12853
Merged
Fix FW logs bug. #12853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Apr 15, 2024
Nir-Az
reviewed
Apr 15, 2024
| { | ||
| fwlogger.stop_collecting(); | ||
|
|
||
| if( !enable_firmware_logs && fwlogger.get_number_of_fw_logs() == 0 ) |
There was a problem hiding this comment.
As I understand from the code, before if the user deactivate the log parsing, we continues dequeue until get_number_of_fw_logs() == 0
Now we will stop even we still have logs as our loop is while( enable_firmware_logs )
Is this change the required behavior?
There was a problem hiding this comment.
"Get logs" HWM can return multiple log entries at once. Those entries are put in a queue. Subsequent calls to get_firmware_log don't send HWM, only deque the messages.
get_number_of_fw_logs() == 0 when the queue is empty, then we break the loop and call stop_collecting
Nir-Az
reviewed
Apr 15, 2024
src/firmware_logger_device.cpp
Outdated
|
|
||
| void firmware_logger_device::HandleReceivedData( std::vector< uint8_t > & res ) |
There was a problem hiding this comment.
Added, and naming convention fixed
Nir-Az
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not parse messages returned for the "start" HWMC, only parsed for the "update" HWMC.
Also the viewer parse the XML repeatedly, changed to parse only once when starting.