added param test_dir in run-unit-tests.py #12874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadiredd
requested review from
Nir-Az,
SamerKhshiboun,
Arun-Prasad-V and
PrasRsRos
PrasRsRos
reviewed
Apr 22, 2024
unit-tests/run-unit-tests.py
Outdated
| @@ -365,6 +377,8 @@ def get_tests(): | |||
|
|
|||
| # Python unit-test scripts are in the same directory as us... we want to consider running them | |||
| # (we may not if they're live and we have no pyrealsense2.pyd): | |||
| if test_dir: | |||
There was a problem hiding this comment.
Please don't change the global variable current_dir, it's used as the script directory also. Use a local variable to assign test_dir or current_dir to search for the tests
There was a problem hiding this comment.
Done. Point taken and incorporated these comments.
Nir-Az
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.