Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFU for D457 recovery device #12944

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

dmipx
Copy link
Contributor

@dmipx dmipx commented May 20, 2024

Tracked-by: [RSDSO-19297] - [D457]: LRS applications cannot recognized cameras in recovery mode
Viewer:
image

rs-fw-update:
image

@dmipx dmipx requested review from Nir-Az, maloel and remibettan May 20, 2024 11:43
@maloel
Copy link
Collaborator

maloel commented May 21, 2024

Can we explain what the problem was?
D457 MIPI devices were recognized before even without all the work done on backend_device_group etc. - so what kept us from recognizing D457 MIPI recovery devices?

src/backend.h Outdated Show resolved Hide resolved
@dmipx
Copy link
Contributor Author

dmipx commented May 21, 2024

Can we explain what the problem was? D457 MIPI devices were recognized before even without all the work done on backend_device_group etc. - so what kept us from recognizing D457 MIPI recovery devices?

recovery devices was never used, we derived dfu device from video device.

@dmipx dmipx force-pushed the dfu-d457-recovery branch from 8dca5bb to b830283 Compare May 21, 2024 12:49
@Nir-Az
Copy link
Collaborator

Nir-Az commented May 26, 2024

@dmipx please rebase development as it has conflicts
src/fw-update/fw-update-device.cpp

@Nir-Az Nir-Az requested a review from maloel May 26, 2024 12:32
@Nir-Az
Copy link
Collaborator

Nir-Az commented May 26, 2024

As discussed let's also notify the user that if the device is D457 and we are recovering form a recovery mode, after the process finish it will not finish with a timeout message he will ask the user to reload the D4xx driver or reboot the platforn

@dmipx dmipx force-pushed the dfu-d457-recovery branch 5 times, most recently from c0472cc to 5a4d30c Compare May 28, 2024 14:53
Tracked-by: [RSDSO-19297] - [D457]: LRS applications cannot recognized cameras in recovery mode

Signed-off-by: Dmitry Perchanov <[email protected]>
@dmipx dmipx force-pushed the dfu-d457-recovery branch from 417d6fe to 91961c2 Compare May 28, 2024 15:15
{
continue;
}
// if (get_devname_from_video_path(real_path, name))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed? please remove

@Nir-Az Nir-Az merged commit 48e1cda into IntelRealSense:development Jun 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants