LRS_LOG_LEVEL fix; enable log optimizations #12978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manual LibCI run: |
|
Will a file be generated now if the user set the env var? librealsense/.github/workflows/buildsCI.yaml Line 303 in ff8a9fb should be probably: path: build/${{env.LRS_RUN_CONFIG}}/*.log
and librealsense/.github/workflows/buildsCI.yaml Line 465 in ff8a9fb Should be |
Yes, I tested this. |
|
Log files are there now |
Nir-Az
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRS_LOG_LEVELwasn't creating log files because of a bug (since #11186, 8-Dec'22) leaving the log filename empty. Tracked on [LRS-1125].Also, PR #12959 optimizations were actually not working: all the levels were still enabled even if to-console and to-file were off! This disables unused log levels and the optimization actually works.