Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dds flow controller #12983

Merged
merged 4 commits into from
May 30, 2024
Merged

Enable dds flow controller #12983

merged 4 commits into from
May 30, 2024

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented May 30, 2024

Following #12924, this actually enables:

  • 1470 max write packet size
  • 256*1470 every 100ms "dfu" flow controller now defined and used in DFU
  • updated scripts/topic-send.py to use a similar flow and adjust the ACK timeout based on the file size

Also:

  • remove topic-sink --time default (was 5), so it waits forever
  • do not show the default FastDDS flow controller "FastDDSFlowControllerDefault" in operator<<

@maloel maloel requested a review from OhadMeir May 30, 2024 05:28
OhadMeir
OhadMeir approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 73c623c into IntelRealSense:development May 30, 2024
17 of 18 checks passed
@maloel maloel deleted the flow-controller branch May 30, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maloel @OhadMeir