Reread calibration tables after applying OCC calibration #13524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Nov 19, 2024
Nir-Az
reviewed
Nov 19, 2024
| @@ -432,6 +432,12 @@ namespace librealsense | |||
| void d500_auto_calibrated::write_calibration() const | |||
| { | |||
| _calib_engine->write_calibration(_curr_calibration); | |||
|
|
|||
| for( auto & cb : _depth_write_callbacks ) | |||
There was a problem hiding this comment.
The write does it inside no?
There was a problem hiding this comment.
Did not understand. _calib_engine->write_calibration() uses a HWMC to write the data to the camera.
The callbacks are to notify users - in this case the device object
Nir-Az
reviewed
Nov 19, 2024
| @@ -463,6 +469,12 @@ namespace librealsense | |||
| void d500_auto_calibrated::reset_to_factory_calibration() const | |||
| { | |||
| throw not_implemented_exception(rsutils::string::from() << "Reset to factory Calibration not applicable for this device"); | |||
|
|
|||
| // Uncomment if function implemented | |||
There was a problem hiding this comment.
Currently D500 calibration logic does not implement (no need) resetting to factory calibration. I just wanted that, if and whenever it might be implemented, we won't forget notifying the callbacks
Nir-Az
reviewed
Nov 19, 2024
Nir-Az
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-490]