Set DDS processing block settings #13625
Open
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
reviewed
Dec 24, 2024
src/dds/rs-dds-sensor-proxy.cpp
Outdated
| else | ||
| if( rsutils::string::nocase_equal( get_name(), "RGB Camera" ) ) | ||
| { | ||
|
|
There was a problem hiding this comment.
Please consider to remove this blank line
remibettan
reviewed
Dec 24, 2024
| @@ -115,6 +115,9 @@ class dds_sensor_proxy : public software_sensor | |||
| virtual void add_no_metadata( frame *, streaming_impl & ); | |||
| virtual void add_frame_metadata( frame *, rsutils::json const & metadata, streaming_impl & ); | |||
|
|
|||
| void add_processing_block_settings( const std::string & filter_name, | |||
| std::shared_ptr< librealsense::processing_block_interface > & ppb ) const; | |||
There was a problem hiding this comment.
why do you need here shared_ptr by reference? It seems to me that you want it by value, so that the copy ctor works, no?
There was a problem hiding this comment.
No, no need to create a new shared_ptr and update the reference count.
It's just a helper function that uses the shared_ptr of the caller, we don't want to store it.
OhadMeir
force-pushed
the
development
branch
from
504063b to
5dde7fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-3017]