Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify content filters for each maven repo #574

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Specify content filters for each maven repo #574

merged 2 commits into from
Apr 7, 2024

Conversation

SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Apr 5, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

Please check if the PR fulfills these requirements

  • The commit message are well described
  • All changes have fully been tested

What kind of change does this PR introduce? (Bug fix, feature, ...)

Bug fix.

What is the current behaviour? (You can also link to an open issue here)

A Gradle build with a clean cache can take a long time, as Gradle attempts to fetch every dependency from every Maven server. Yesterday I was having some connectivity issues to mvn.intelligence-modding.de, which caused just downloading Forge to take 10 minutes (let alone any of the mod dependencies)!

What is the new behaviour (if this is a feature change)?

This now adds content filters to all of the additional repos, meaning Gradle will now only try to download from:

  • Maven Central
  • NeoForged's repo
  • The specific repo where the dependency is located.

We could prevent searching Maven Central and NeoForge by using exclusiveContent (example in Mekanism), but that's a bit of a bigger change

@SirEndii SirEndii self-requested a review April 5, 2024 16:03
@SirEndii SirEndii merged commit f688819 into IntelligenceModding:dev/1.20.1 Apr 7, 2024
2 checks passed
@SquidDev SquidDev deleted the maven-content-specs branch April 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants