-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunky Turtle Logic Rework #576
Conversation
and fix ConcurrencyModification when removing record during forEach the map
@SirEndii This PR is ready for further review, however, changes were not fully tested yet. I'll do more test when I get time. Needs to test<List moved to the top> |
@SirEndii Do you think add a subcommand If we add this command, server owner can keep track on what's using their resources. |
Yeah |
@SirEndii All of the tests I can think of are done, except test on pure server. I don't think it's really necessary, but will try if I got more time. ;) |
Thank you for the PR(s)! |
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
As guideline said, the 1.19.2 version is at #582 (just sync the patches in this PR)
Fix chunky turtle's behaviour.
Now the chunky turtle sometimes will not works, especially after server restart.
What is the new behavior (if this is a feature change)?Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
If some player made their structure depends on the unstable chunk loading, then it will be a breaking change.
Needs to test
/advancedperipherals forceload
and its subcommands