Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunky Turtle Logic Rework #576

Merged
merged 17 commits into from
Apr 22, 2024
Merged

Conversation

zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Apr 6, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

As guideline said, the 1.19.2 version is at #582 (just sync the patches in this PR)

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)

Fix chunky turtle's behaviour.

  • What is the current behavior? (You can also link to an open issue here)

Now the chunky turtle sometimes will not works, especially after server restart.

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

If some player made their structure depends on the unstable chunk loading, then it will be a breaking change.

  • Other information:

Needs to test

  • Chunk will be forced when turtle is actived.
  • Chunk will be forced when turtle enter chunk border.
  • Chunk will unforce after remove turtle / turtle exit the chunk.
  • Chunk will unforce when turtle left chunk border.
  • Chunk will unforce when time expired.
  • Chunks will be saved after server stopped.
  • Chunks will be loaded after server started.
  • Test to break the turtle, and put it back in another chunk before cleanup.
  • Test with larger radius.
  • Test change radius from small to large.
  • Test change radius from large to small.
  • Test /advancedperipherals forceload and its subcommands
  • Test on pure server.
  • Maybe more ...

@zyxkad zyxkad changed the title start to fix chunky peripheral Fix chunky peripheral Apr 6, 2024
@zyxkad zyxkad changed the title Fix chunky peripheral Fix chunky turtle Apr 6, 2024
@SirEndii SirEndii changed the title Fix chunky turtle Chunky Turtle Logic Rework Apr 11, 2024
@zyxkad zyxkad marked this pull request as ready for review April 13, 2024 04:35
@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 13, 2024

@SirEndii This PR is ready for further review, however, changes were not fully tested yet. I'll do more test when I get time.

Needs to test

<List moved to the top>

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 13, 2024

@SirEndii Do you think add a subcommand /advancedperipherals forceload will be a good idea? because I found out the vanilla /forceload will not show the chunks loaded by chunky turtles, /computercraft dump will show all computers but not only chunky turtle.

If we add this command, server owner can keep track on what's using their resources.

@SirEndii
Copy link
Member

@SirEndii Do you think add a subcommand /advancedperipherals forceload will be a good idea? because I found out the vanilla /forceload will not show the chunks loaded by chunky turtles, /computercraft dump will show all computers but not only chunky turtle.

If we add this command, server owner can keep track on what's using their resources.

Yeah
That sounds like a good idea

@SirEndii SirEndii self-requested a review April 15, 2024 21:03
@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 19, 2024

@SirEndii All of the tests I can think of are done, except test on pure server. I don't think it's really necessary, but will try if I got more time. ;)

@SirEndii
Copy link
Member

Thank you for the PR(s)!
The new chunk system looks good, I will address the deprecated functions when I finish the port to 1.20.4

@SirEndii SirEndii merged commit 42757d7 into IntelligenceModding:dev/1.20.1 Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Chunks loaded by chunky turtles are not loaded upon reloading the world
2 participants