-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tamed turtle #601
Add tamed turtle #601
Conversation
7fe2be7
to
dea2e60
Compare
HUD stuff to show turtle fuel require Mixins and a read lot of minecraft asm, I don't think if I can done that recently. If I got the HUD bar working, I'll make another PR |
As well as the saddle turtle's model need better saddle drawing, rather than just show the saddle on the side ... |
But anyways, forge already did that mixin for you, so the HUD is done 💦 |
also make the minimum action cooldown to 100ms
…ncedPeripherals into tamed-turtle-patch
Signed-off-by: Kevin Z <[email protected]>
…ncedPeripherals into tamed-turtle-patch
@SirEndii This is ready for review again |
gonna review that tomorrow |
src/main/java/de/srendi/advancedperipherals/common/util/LuaConverter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
capture
peripheral method, andrelease
for dismountgetRider
to get the information of the captured entityE
) can open the turtle's GUIDoes this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
Other information: